hi!

hi

I'm a comp sci student and have also been trading monero for nearly 1 yr

I would like to help out on any projects happening!

Welcome. What's your area of expertise, and what's your area of preference ?

I would like to start with GUI stuff, and as far as expertise i'm somewhat experienced in C++/Objected oriented programming/Algorithm and data structures/web development but not any skills directly related to GUI. I would like to volunteer and to gain experience

Try asking in #monero-gui then.

Thanks

homeslice: this could be a good starting point for you as well: sethsimmons.me/posts/contributing-to-monero/#for-developers

sethsimmons I'll take a look into it, cheers

.merge+ 7371

Added

I was looking through the database and saw that the string comparator for the properties table does not take size into account

when we do  MDB_val_str(k, "pruning_seed");

the right hand argument is cast to a void *,that is (void * ) "pruning_seed"

In c++ is pruning seed automatically converted to a C-style string when we write something like this?

IIRC the zero is stored.

(for this particular table)

It has to be. But where does it happen do you know?

I'm not sure I understand what you're asking here.

where is the null terminator set

I wouldn't have thought it was done during the (void   *) cast

ffs

void star

haha

I don't understnad what you're asking here.

The NUL terminator is set at the end of the string. Obviously. So that's probably not what you're asking.

The cast doesn't change this.

The cast is because the MDB_val data arg is a void* since it can point to anything.

c++ style strings don't have a null terminator. std::string temp = "hello whats up"; will not have a null termiator

if we simply write "some text" without writing std::string, is it interpreted as a C-style string with a null terminator?

It shuld have one since c_str needs one.

It's a C string.

right

thanks

You could make a custom compare function that strncmp, but lmdb will crash happily if you craft the db anyway, so it really doesn't matter I think.

Why is it people want to file a bug about expcetions all the bloody time if it's working...

It doens't show on the console for a reason...

Arkoo: a C++ string does contain a NULL terminator. It's just not counted in with size().

Comparing const char * with string's c_str() will work for strncmp

is there anything 'wrong' with setting p2p-bind-port=80 on my home daemon? Thank you

moneromooo: could you unlock xmronadaily on gitlab. It's the problem of the login with github.

Sure. I totally forgot about doing those rounds for ages.

nobody had complained about it so far :)

Funny that. It asks for for 2FA, and I did not set that up.

ErCiccione: it will wait, I have login issues to the admin interface.

Alright, thanks. I think serhack has access has well.

If all goes well, this channel will be bridged to the Discord tonight. It was bridged before, but if you have concerns lmk

eh? there are actual developer on discord that aren't on irc?

Seems all large enough monero channels will get bridged. Should allow everyone to get persistence without bouncer or paying for irccloud. Easier for some people

Matrix is much better and more private and should be the recommendation.

But discord is good for normies

Should only be RO to this channel though.

yeah RO here sounds like a good idea