08:40:07 <ErCiccione> was this included in a release? https://github.com/monero-project/monero/pull/7412
08:42:02 <ErCiccione> A request to the devs: please be more descriptive in your PRs. I'm really trying to update the documentation, but between unanswered requests and PRs that are literally only code, i'm having a very hard time.
08:42:45 <ErCiccione> even just a short description would be something. Or an example of the parameters needed for the RPC call.
08:44:42 <ErCiccione> and since we are in therme. Reminder that https://github.com/monero-project/monero-site/pull/1448 still needs definitions that i don't know where to find.
08:46:11 <ErCiccione> The definitions that still need to be added: https://github.com/monero-project/monero-site/pull/1448#issuecomment-772419506
09:11:14 <selsta> 7412 is not included in a release
10:37:07 <ErCiccione> thanks selsta
12:10:09 <tobtoht> ErCiccione: "A request to the devs:" -> I will keep that in mind next time.
12:25:22 <ErCiccione> tobtoht: thank you 🙂 I think for the future would be good to have some kind of policy or workflow to assure the docs are updated along with the code
13:09:14 <selsta> let's not have more policy's :D
13:10:51 <selsta> or do you mean just document if you add something to rpc?
13:20:24 <ErCiccione> yeah i don't mean a policy. I mean that if we want to have documentation updated, we need to coordinate
13:21:21 <ErCiccione>  i already asked during the years to make more verbose pull requests, but if it's not a requirement the request is soon forgotten, or new people are not aware of the problem
13:22:09 <ErCiccione> if we could have more verbose PRs and more coordination, everybody would benefit
13:22:40 <sethsimmons> Should a note/comment on that be added to the contributing guidelines (if not already there)?
13:22:43 <ErCiccione> but yeah even just open an issue on monero-site when RPC calls are added/edited/removed would be a huge help
13:22:50 <sethsimmons> That's probably the best home for best-practices like that.
13:22:53 <ErCiccione> sethsimmons: nobody reads those
13:23:07 <ErCiccione> especially our contributing file which is huge
13:24:34 <ErCiccione> the thing who would really help is maintainer enforcing the practice of more detailed PRs
13:24:42 <ErCiccione>  * the thing who would really help is maintainers enforcing the practice of more detailed PRs
13:25:27 <ErCiccione> but as i said, an issue on monero-site would also help. If not an issue, a ping on #monero-site at least
13:26:42 <ErCiccione> would be probably a good idea to trim the CONTRIBUTING file regardless. AFAIK there is the entire C4 in it. Removing that would make the file much smaller already
13:26:50 <selsta> What do you mean with "more detailed" PR? E.g. 7412 adds a RPC call for the scan_tx feature. What would you explain in detail here?
13:27:21 <selsta> (Apart from documentation for the RPC call)
13:29:11 <ErCiccione> i think in general would be helpful to be more verbose, but my point now is to make easier documenting RPC changes. So, either more info in the PR or directly open an issue/ping me.
13:29:30 <ErCiccione> Basically, whatever will make things best without being too annoying for the devs would be fine IMO
14:31:52 <selsta> .merge+ 7481
14:31:52 <xmr-pr> Added
14:32:02 <selsta> .merges
14:32:02 -xmr-pr- 7349 7416 7481 7661 7662 7684 7729 7730