cohcho: "monero-pool can set diff higher than block difficulty" whare are you refering to in the source?

cohcho: "it's not ready for production" really? a) first pool to support rx b) only pool that does full rx mode (could go on)

Welcome contributions though!

function retarget that updates miner's diff

doesn't have fmin(target, job->block_template->difficulty)

I mean as plug&play solution not ready

I'm using now after few fixes

s/fmin/min

target != difficulty

wait, let me check

they are different things

"I mean as plug&play solution" <- no, there is no Dockerfile if that's what you mean.

"fmin(target, job->block_template->difficulty)" <- would be wrong, as I say, target is not the same thing as block difficulty.

you're wrong: in your code job->target equals to diff from monerod

functino target_to_hex produces hex of something that is called target in monerod

and job->target can be set higher diff in monerod

i'm right, check your code

there is no "target in monerod"

let me check

target is a stratum specific thing

you will find a near identical retarget in nodejs-pool

I didn't use nodejs-pool

from monerod: check_hash_64(hash, difficulty.convert_to<std::uint64_t>())

result of `difficulty.convert_to()` is called target

and difficulty itselt is difficulty

in your code job->target equals to difficulty

no no no

it does not.

and target_to_hex(job->target) equals to difficulty.convert_to but reduced to 32bits

If i'm wrong then i need more time to realize it

look at node-js updateDifficulty

difficulty and target (the words) get interchanged a lot in the pool(s).

block difficulty (at least in monero-pool, cant remember nodesjs) is the actual normal block difficulty.

target is something else. it still relates to difficulty, but it is not the same.

Write here something like: "I'm sure that monero-pool can't set miner's job complexiter higher that required for actual block"

And i'm will be fine

complexity*

I am absolutely positive.

Because of the difficulty cap more than anything else.

Both of the main node pool imeplementations have a ceiling I think.

Snipa, can you check his code?

You got a link? I haven't looked in forever.

trace retarget() function call and how it is being passed to miner via json

I gathered, I just don't know where trhe source code is offhand.

Snipa: github.com/jtgrassie/monero-pool/blob/master/src/pool.c#L831 which is essentially the same is github.com/Snipa22/nodejs-pool/blob/master/lib/pool.js#L401

yes, that link

cohcho is not grasping how startum target does not equal monero block difficulty.

It does, technically.

well yes, in reverse

The stratum target is the mindiff required to hit.

Technically, that code doesn't have a ceiling.

awesome!

neither does nodejs

It does: github.com/Snipa22/nodejs-pool/blob/master/lib/pool.js#L418

they don't need it

We lock you out during the set. :P

But that was more to deal with dumb miners who set massive diffs then complained about never finding shares.

But yeah, it shouldn't need it in general, as you're using the share target time, and submitted hashes.

"We lock you out during the set." thats the pool max target setting, not block diff.

Yeah, which is always less than block diff.

Unless network diff drops to sub 500k.

hmmm

Auctually, I think it's still 20-30k in the default config, haven't looked at that in forever.

So you could, in theory, if the math was extra screwball in your code, send a diff target > the current block target.

so much worsds, and no explicit answer yes or no

But the overall of that code tells me it's not likely to happen.

that's why i don't spend time of pull requests

My instinct says "No, you're not going to send a target > block diff." just because you're using the client hashrate to determine the target.

It is, /technically/ a possibility, but it's one I don't see happening any time soon.

1st time use and it's just happened to me on testnet

Sure, and that makes sense, as your hashrate is far exceeding the network difficulty on testnet.

another ting for plug&play: data-dir for lmdb is missing and will tigger assert in code

^ thanks. I see the issue there. if supplied path doesn't exist

few typos in strings are not important at all

yeah I have a couple of commits waiting to push with a typo or tow

;)

If someone will double spend monero then it must not be done on weekends.

I've just push the commits I had sitting. If there's a typo I have missed let me know please.

at first glance memory footprint of your pool is the best

cohcho: jtgrassie/monero-pool e3e133f

thanks

^ +Snipa

Shiny.

1 gigahash

total miners 26292

wow. the electric bill is a lot lower this month!

heh, is it? gingeropolous.

how comes.

most of the GPUs are off I guess. and I didn't get everything online at once for randomx...