was this included in a release? monero-project/monero #7412

A request to the devs: please be more descriptive in your PRs. I'm really trying to update the documentation, but between unanswered requests and PRs that are literally only code, i'm having a very hard time.

even just a short description would be something. Or an example of the parameters needed for the RPC call.

and since we are in therme. Reminder that monero-project/monero-site #1448 still needs definitions that i don't know where to find.

The definitions that still need to be added: monero-project/monero-site #1448#issuecomment-772419506

7412 is not included in a release

thanks selsta

ErCiccione: "A request to the devs:" -> I will keep that in mind next time.

tobtoht: thank you 🙂 I think for the future would be good to have some kind of policy or workflow to assure the docs are updated along with the code

let's not have more policy's :D

or do you mean just document if you add something to rpc?

yeah i don't mean a policy. I mean that if we want to have documentation updated, we need to coordinate

i already asked during the years to make more verbose pull requests, but if it's not a requirement the request is soon forgotten, or new people are not aware of the problem

if we could have more verbose PRs and more coordination, everybody would benefit

Should a note/comment on that be added to the contributing guidelines (if not already there)?

but yeah even just open an issue on monero-site when RPC calls are added/edited/removed would be a huge help

That's probably the best home for best-practices like that.

sethsimmons: nobody reads those

especially our contributing file which is huge

the thing who would really help is maintainer enforcing the practice of more detailed PRs

* the thing who would really help is maintainers enforcing the practice of more detailed PRs

but as i said, an issue on monero-site would also help. If not an issue, a ping on #monero-site at least

would be probably a good idea to trim the CONTRIBUTING file regardless. AFAIK there is the entire C4 in it. Removing that would make the file much smaller already

What do you mean with "more detailed" PR? E.g. 7412 adds a RPC call for the scan_tx feature. What would you explain in detail here?

(Apart from documentation for the RPC call)

i think in general would be helpful to be more verbose, but my point now is to make easier documenting RPC changes. So, either more info in the PR or directly open an issue/ping me.

Basically, whatever will make things best without being too annoying for the devs would be fine IMO

.merge+ 7481

Added

.merges